Umbra Wiki weakness weakness/CWE-558
Back to wiki

CWE-558 — Use of getlogin() in Multithreaded Application

provenance: imported · CWE: CWE-558

CWE-558: Use of getlogin() in Multithreaded Application

MITRE CWE weakness

Kind Weakness
Abstraction Variant
Status Draft
Likelihood of exploit

Description

The product uses the getlogin() function in a multithreaded context, potentially causing it to return incorrect values.

The getlogin() function returns a pointer to a string that contains the name of the user associated with the calling process. The function is not reentrant, meaning that if it is called from another process, the contents are not locked out and the value of the string can be changed by another process. This makes it very risky to use because the username can be changed by other processes, so the results of the function cannot be trusted.

Common consequences

  • Integrity, Access Control, Other: Modify Application Data, Bypass Protection Mechanism, Other

Mitigations

Architecture and Design — Using names for security purposes is not advised. Names are easy to forge and can have overlapping user IDs, potentially causing confusion or impersonation.

Implementation — Use getlogin_r() instead, which is reentrant, meaning that other processes are locked out from changing the username.

References

  • CWE page: https://cwe.mitre.org/data/definitions/558.html
  • CWE list: https://cwe.mitre.org/data/index.html